Request for reviews .02 (M): 6961697: move nmethod constants section before instruction section

Christian Thalinger christian.thalinger at oracle.com
Wed Aug 25 06:40:43 PDT 2010


On Mon, 2010-08-23 at 08:34 -0700, Tom Rodriguez wrote:
> I think rearranging the all the section names wasn't really needed
> particularly in CodeBuffer since the ordering the buffer didn't
> change.  You don't need to undo though it.  

Yeah, right.

> Please correct the comment here:
> 
>       // Here is the list of all possible sections, in order of ascending address.
> +     SECT_FIRST = 0,
> +     SECT_CONSTS = SECT_FIRST, // Non-instruction data:  Floats, jump tables, etc.
>       SECT_INSTS,               // Executable instructions.
>       SECT_STUBS,               // Outbound trampolines for supporting call sites.
>       SECT_CONSTS,              // Non-instruction data:  Floats, jump tables, etc.
>       SECT_LIMIT, SECT_NONE = -1

Done.

> 
> Since the address ordering in CodeBuffers hasn't changed.  I think
> relocate relocate_code_to should have some more comments explaining
> that reordering is occurring too.

Added a comment.

http://cr.openjdk.java.net/~twisti/6961697/webrev.03/

-- Christian



More information about the hotspot-compiler-dev mailing list