Request for reviews (S): 7192167: JSR 292: C1 has old broken code which needs to be removed

[Christian Thalinger]

On Aug 20, 2012, at 10:29 AM, John Rose <john.r.rose at oracle.com> wrote:

> On Aug 20, 2012, at 9:51 AM, Christian Thalinger wrote:
> 
>> On Aug 18, 2012, at 3:12 PM, John Rose <john.r.rose at oracle.com> wrote:
>> 
>>> Looks good. What tests now pass and how did you test the change?
>> 
>> There were no failing tests because the force inline hid it.  I did testing with Nashorn and JRuby with -XX:-Inline.
> 
> Good  -XX:-Inline counts as a stress test.  We should do it more often, since we know our code is sensitive to it.
> 
> Let's add -XX:-Inline as an extra mode in one of our jtreg tests, such as MethodHandlesTest.  This can be done by duplicating the @test block with the changed @run option.

Good idea.  We need to fix some other tests anyway to cut run time a bit.  Then we can add this too.

-- Chris

> 
> — John