Request for reviews (S): 7192167: JSR 292: C1 has old broken code which needs to be removed

[John Rose]

On Aug 20, 2012, at 9:51 AM, Christian Thalinger wrote:

> On Aug 18, 2012, at 3:12 PM, John Rose <john.r.rose at oracle.com> wrote:
> 
>> Looks good. What tests now pass and how did you test the change?
> 
> There were no failing tests because the force inline hid it.  I did testing with Nashorn and JRuby with -XX:-Inline.

Good  -XX:-Inline counts as a stress test.  We should do it more often, since we know our code is sensitive to it.

Let's add -XX:-Inline as an extra mode in one of our jtreg tests, such as MethodHandlesTest.  This can be done by duplicating the @test block with the changed @run option.

— John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20120820/2a4e055b/attachment-0001.html