Request for reviews (M): 7145346: VerifyStackAtCalls is broken

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Feb 16 11:04:08 PST 2012


http://cr.openjdk.java.net/~kvn/7145346/webrev

7145346: VerifyStackAtCalls is broken

A lot of duplicated code was removed.

The failure was due to an incorrect branch distance was used in call_epilog(). 
Replace it's encoding with macroassembler use. Moved duplicated code to x86.ad.

After that fix I found an other problem - return_addr() definition in .ad files 
was not taking into account EBP save. Used in_preserve_stack_slots() value which 
is correctly defined. Also fixed frame dump for OptoAssembly output (in 
chaitin.cpp).

Thanks,
Vladimir


More information about the hotspot-compiler-dev mailing list