Request for reviews (M): 7145346: VerifyStackAtCalls is broken

[Tom Rodriguez]

On Feb 16, 2012, at 11:04 AM, Vladimir Kozlov wrote:

> http://cr.openjdk.java.net/~kvn/7145346/webrev
> 
> 7145346: VerifyStackAtCalls is broken
> 
> A lot of duplicated code was removed.

Very nice.  In chaitin.cpp, regs_per_slot can be replaced with VMRegImpl::slots_per_word.

> 
> The failure was due to an incorrect branch distance was used in call_epilog(). Replace it's encoding with macroassembler use. Moved duplicated code to x86.ad.
> 
> After that fix I found an other problem - return_addr() definition in .ad files was not taking into account EBP save.

What kind of bug could that lead to?  Or does it just work out to be benign?

tom

> Used in_preserve_stack_slots() value which is correctly defined. Also fixed frame dump for OptoAssembly output (in chaitin.cpp).
> 
> Thanks,
> Vladimir