review(XS): 7131288: COMPILE SKIPPED: deopt handler overflow (retry at different tier)

[Tom Rodriguez]

On Jan 18, 2012, at 7:18 PM, Vladimir Kozlov wrote:

> Why not use should_not_reach_here() in deopt stub? Also x86 deopt stub does not have stop() or should_not_reach_here().

I think the stop should be removed from emit_deopt_handler on sparc since it's preceded by a direct jump.  Usually we emit a stop when we do a call that we don't expect to return, like for an exception dispatch, but in this case since it's a jump it's really impossible the reach the following instruction.

tom

> 
> Vladimir
> 
> Igor Veresov wrote:
>> After 701291 we started generating should_not_reach() code in product VM in LIR_Assembler::emit_exception_handle()
>> which is significantly bigger than exception_handler_size for product VM. It seems that we generate should_not_reach for all other platforms, so I decided to leave it for sparc too. I adjusted the sizes for stubs so that they are the same in product and debug, which should enable the assert that checks for the overflow to make sense. Did the same for deopt stub too.
>> Webrev:  http://cr.openjdk.java.net/~iveresov/7131288/webrev.00/
>> igor