Request for review (XS): 7132180: JSR 292: C1 JVM crash with ClassValue/MethodHandle
Tom Rodriguez
tom.rodriguez at oracle.com
Mon Jan 30 08:14:33 PST 2012
Looks good.
tom
On Jan 30, 2012, at 2:29 AM, Christian Thalinger wrote:
> http://cr.openjdk.java.net/~twisti/7132180/
>
> 7132180: JSR 292: C1 JVM crash with ClassValue/MethodHandle
> Reviewed-by:
>
> The logic for detecting the selectAlternative idiom in
> GraphBuilder::for_method_handle_inline assumes that both inputs of the
> phi node are constant. This might now be the case.
>
> The fix is to check for is_constant on the ObjectType of both inputs.
>
> Tested with failing test.
>
> src/share/vm/c1/c1_GraphBuilder.cpp
>
More information about the hotspot-compiler-dev
mailing list