RFR: 8267356: AArch64: Vector API SVE codegen support [v4]
Ningsheng Jian
njian at openjdk.java.net
Mon Aug 9 07:16:58 UTC 2021
On Tue, 3 Aug 2021 10:20:56 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Ningsheng Jian has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add missing part
>
> src/hotspot/cpu/aarch64/assembler_aarch64.cpp line 70:
>
>> 68:
>> 69: Assembler::SIMD_Arrangement Assembler::esize2arrangement(unsigned esize, bool isQ) {
>> 70: assert(esize < ARRAY_SIZE(_esize2arrangement_table) &&
>
> Please consider making this a guarantee. The cost is minimal, and we've been saved by guarantees elsewhere in this file.
Done.
> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 957:
>
>> 955: case BoolTest::eq: condition = Assembler::EQ; break;
>> 956: case BoolTest::ne: condition = Assembler::NE; break;
>> 957: case BoolTest::le: z1 = zm; z2 = zn; // Swap the two inputs
>
> This might warn on some targets, so we'd need to fix it anyway, so please do it now. Better to duplicate the action and break.
Addressed in the new commit. Thanks!
-------------
PR: https://git.openjdk.java.net/jdk/pull/4122
More information about the hotspot-compiler-dev
mailing list