RFR: JDK-8293480: IGV: Update Bytecode and ControlFlow Component immediately when opening a new graph [v4]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Wed Sep 14 11:47:37 UTC 2022


On Fri, 9 Sep 2022 13:10:59 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> The `BytecodeViewTopComponent` and `ControlFlowTopComponent` represent information depending on what graph is open in `EditorTopComponent`. Previously, `BytecodeViewTopComponent` and `ControlFlowTopComponent` did not update its content immediately when a new graph from a different group is opened in `EditorTopComponent`. They also did not update when switching between two tabs of open graph. 
>> 
>> We missed to `fire()` a `diagramChangedEvent` in the constructor of `EditorTopComponent`. We also need to fire when `BytecodeViewTopComponent` and `ControlFlowTopComponent` are initially opened. 
>> <img width="1291" alt="Update" src="https://user-images.githubusercontent.com/71546117/188860123-825a67fd-aab3-4500-8a47-8fa56eb9aeed.png">
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update Bytecode and ControlFlow when a group is removed

Thanks for addressing the additional case, Tobias. I found an issue in the new revision, though: the graph selected in the Outline is not updated when clicking on the "Show previous / next graph of the current group" buttons. Furthermore, after clicking a few times forward and backwards (~20 times or more), IGV becomes very unresponsive (tens of seconds to update the graph view).

-------------

Changes requested by rcastanedalo (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10196


More information about the hotspot-compiler-dev mailing list