RFR: JDK-8293480: IGV: Update Bytecode and ControlFlow Component immediately when opening a new graph [v5]

Tobias Holenstein tholenstein at openjdk.org
Thu Sep 15 15:09:01 UTC 2022


> The `BytecodeViewTopComponent` and `ControlFlowTopComponent` represent information depending on what graph is open in `EditorTopComponent`. Previously, `BytecodeViewTopComponent` and `ControlFlowTopComponent` did not update its content immediately when a new graph from a different group is opened in `EditorTopComponent`. They also did not update when switching between two tabs of open graph. 
> 
> We missed to `fire()` a `diagramChangedEvent` in the constructor of `EditorTopComponent`. We also need to fire when `BytecodeViewTopComponent` and `ControlFlowTopComponent` are initially opened. 
> <img width="1291" alt="Update" src="https://user-images.githubusercontent.com/71546117/188860123-825a67fd-aab3-4500-8a47-8fa56eb9aeed.png">

Tobias Holenstein has updated the pull request incrementally with two additional commits since the last revision:

 - Revert "update TopComponents on closing"
   
   This reverts commit 49dbaa319cf72a0c16d4f9d3501c09d295744388.
 - Revert "Update Bytecode and ControlFlow when a group is removed"
   
   This reverts commit e908804316e3831aaaca37d0145dc8e5405c172d.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10196/files
  - new: https://git.openjdk.org/jdk/pull/10196/files/e9088043..2a643165

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10196&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10196&range=03-04

  Stats: 126 lines in 9 files changed: 51 ins; 60 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/10196.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10196/head:pull/10196

PR: https://git.openjdk.org/jdk/pull/10196


More information about the hotspot-compiler-dev mailing list