RFR: 8294245: Make Compile::print_inlining_stream stack allocated [v2]
Johan Sjölen
jsjolen at openjdk.org
Sat Sep 24 10:18:11 UTC 2022
On Sat, 24 Sep 2022 10:09:26 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Hi,
>>
>> Could I have a review for this? It simplifies some auxiliary code in the Compile class related to its usage of stringStream. The only notable disadvantage is that Compile will take up `sizeof(stringStream) - sizeof(stringStream*)` more space on the stack.
>>
>> Currently testing tier1-3 for this change, no errors yet and almost finished.
>>
>> Thanks,
>> Johan
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>
> Make it heap allocated, but only delete at dtr
Pushed a bit too early :-). Anyway, here's the heap allocated version, still removes the cruft of the earlier version.
-------------
PR: https://git.openjdk.org/jdk/pull/10396
More information about the hotspot-compiler-dev
mailing list