RFR: 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1

Tobias Hartmann thartmann at openjdk.org
Tue Dec 5 08:16:03 UTC 2023


The test fails with `-XX:CompileThreshold=100 -XX:TieredStopAtLevel=1` because `CompileMethodHolder::nonTrivialMethod` is unexpectedly OSR compiled but the test case has `isOSR() == false` (see line 197). The test is indeed not supposed to trigger an OSR compilation, and usually won't, but the loop is required to test tiered level transitions of a non-trivial method containing a loop. I simply changed the iterations to 1 to make sure that the backedge is never taken and thus prevent unexpected OSR compilations. The method will still be detected to have a loop and serve its purpose.

Thanks,
Tobias

-------------

Commit messages:
 - 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1

Changes: https://git.openjdk.org/jdk/pull/16964/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16964&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8318468
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/16964.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16964/head:pull/16964

PR: https://git.openjdk.org/jdk/pull/16964


More information about the hotspot-compiler-dev mailing list