RFR: 8300109: RISC-V: Improve code generation for MinI/MaxI nodes [v2]

Fei Yang fyang at openjdk.org
Sat Jan 14 05:35:09 UTC 2023


On Fri, 13 Jan 2023 10:18:53 GMT, Dmitry Chuyko <dchuyko at openjdk.org> wrote:

>> Fei Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comment
>
> src/hotspot/cpu/riscv/riscv.ad line 8706:
> 
>> 8704: // avoids loading constant 0 into a source register
>> 8705: 
>> 8706: instruct minI_reg_zero(iRegINoSp dst, immI0 zero)
> 
> As mentioned in https://github.com/openjdk/jdk/pull/11570, unfortunately the order of immediate in MinI/MaxI is not quaranteed, at least it is so in Ideal().

Yes, I think you are right. Added another two match rules for that case.

-------------

PR: https://git.openjdk.org/jdk/pull/11988


More information about the hotspot-compiler-dev mailing list