RFR: JDK-8300240: Replace NULL with nullptr in share/ci/

Johan Sjölen jsjolen at openjdk.org
Mon Jan 23 12:31:13 UTC 2023


On Fri, 20 Jan 2023 19:37:02 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> > Regarding the confusion regarding `null` and `nullptr` in comments :). Yes, the idea is that we use `null` in comments as it reads better. In _some_ situations I've chosen to keep `nullptr` in comments, this is specifically when there are code
> 
> As owner of the code I prefer to match comments and code.
> 
> > This was discussed in a previous review, as you suspected.
> 
> Please, point me to that discussion.

Sure, the original PR where this was discussed is this one (with :  https://github.com/openjdk/jdk/pull/12015#issuecomment-1396711466

And here is Robbin's input: https://github.com/openjdk/jdk/pull/12094#issuecomment-1399978529

-------------

PR: https://git.openjdk.org/jdk/pull/12029


More information about the hotspot-compiler-dev mailing list