RFR: 8311087: PhiNode::wait_for_region_igvn should break early

Johan Sjölen jsjolen at openjdk.org
Thu Jun 29 10:50:03 UTC 2023


Hi, please consider this PR.

Instead of continuing the loop we break after setting `delay = true`. I also flattened out the indentation by transforming `A && B` into `!A || !B` and `continue`ing if so. This makes the code a bit longer, but clearer imho.

I've run `TestCastIIAfterUnrollingInOuterLoop`, which is the test that was added along with this method. I'm also running tier1.

Thanks,
Johan

-------------

Commit messages:
 - Do it.

Changes: https://git.openjdk.org/jdk/pull/14707/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14707&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8311087
  Stats: 24 lines in 1 file changed: 4 ins; 0 del; 20 mod
  Patch: https://git.openjdk.org/jdk/pull/14707.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14707/head:pull/14707

PR: https://git.openjdk.org/jdk/pull/14707


More information about the hotspot-compiler-dev mailing list