RFR: 8282365: Consolidate and improve division by constant idealizations [v42]

[Kim Barrett]

On Mon, 8 Jan 2024 09:25:53 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> I was told that `unittest.hpp` should come last so this is the order, I have added a line between JDK header and stdlib header as well as resolved your other comments. Thanks a lot.
>
> The rules around the includes lines in our tests and what we currently have in the tests are messy at the movement. We should fix that when we find the time to.
> 
> For HotSpot source code files the includes should be structured as::
> 
> hotspot includes
> blank line
> system includes
> 
> 
> There are some deviations from that, but those should be cleaned up instead of used as a precedence. For our tests we should add "unittest.hpp" at the end of the "hotspot includes" section.

In the Oracle-internal discussion of include order from about a year ago, there was not a consensus
decision about the position of "unittest.hpp".  There was a concern that in some cases it really was
required to be last for some technical reason.  That needed (and still needs) investigation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9947#discussion_r1444358649