RFR: 8282365: Consolidate and improve division by constant idealizations [v42]

[Quan Anh Mai]

On Mon, 8 Jan 2024 09:44:51 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> The rules around the includes lines in our tests and what we currently have in the tests are messy at the movement. We should fix that when we find the time to.
>> 
>> For HotSpot source code files the includes should be structured as::
>> 
>> hotspot includes
>> blank line
>> system includes
>> 
>> 
>> There are some deviations from that, but those should be cleaned up instead of used as a precedence. For our tests we should add "unittest.hpp" at the end of the "hotspot includes" section.
>
> In the Oracle-internal discussion of include order from about a year ago, there was not a consensus
> decision about the position of "unittest.hpp".  There was a concern that in some cases it really was
> required to be last for some technical reason.  That needed (and still needs) investigation.

I assume this means that the include order is good as it is now?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9947#discussion_r1446242593