RFR: 8332394: Add friendly output when @IR rule missing value [v2]
Emanuel Peter
epeter at openjdk.org
Tue May 21 08:09:06 UTC 2024
On Fri, 17 May 2024 06:32:41 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Good catch! Only a small improvement suggestion, otherwise, looks good.
>>
>> Just noticed that we are actually missing tests that trigger a format violation in `TestBadFormat` for `applyIfCPUFeature*` and `applyIfPlatform*`. We should probably add some at some point, analogously to the ones already there for `applyIf*` for flags. But that could be done separately.
>
> Thanks @chhagedorn for your reviewing!
@Hamlin-Li you only got 1 review. Per the rules, you generally need 2:
https://openjdk.org/guide/#final-check-before-creating-the-pr
That is unless you say that the change is **trivial**, and the reviewer also confirms that it is **trivial**. I don't see that here.
Our rule is that you need 2 reviewers: at least one reviewer, the second one can be a committer.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19270#issuecomment-2122017305
More information about the hotspot-compiler-dev
mailing list