RFR: 8330159: [C2] Remove or clarify Compile::init_start [v5]

Yagmur Eren duke at openjdk.org
Tue Sep 3 12:42:26 UTC 2024


On Tue, 3 Sep 2024 09:39:36 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Yagmur Eren has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adding NOT_DEBUG_RETURN instead of DEBUG_ONLY for Compile::verify_start
>
> src/hotspot/share/opto/compile.cpp line 1109:
> 
>> 1107: 
>> 1108: #ifdef ASSERT
>> 1109: // Install the StartNode on this compile object.
> 
> I think this comment needs to be updated.

I believe the following may sound good briefly?: "Verify that the current StartNode is valid."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20715#discussion_r1741992128


More information about the hotspot-compiler-dev mailing list