RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v13]

[Emanuel Peter]

On Tue, 17 Sep 2024 08:12:24 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move some code around
>
> test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java line 87:
> 
>> 85: 
>> 86:         Compile.compileJasmSources(jasmSources, sourceDir, classesDir);
>> 87:         Compile.compileJavaSources(javaSources, sourceDir, classesDir);
> 
> Suggestion: Instead of having two static methods, how about making the `sourceDir` and `classesDir` fields of `Compile`? Then you can reuse them inside the class without passing them around (with these methods being member methods).

That is why those methods were originally part of the `ComileFramework`, as fields... I think it is easier to pass them as arguments, because that way one can directly and easily understand what are the components that go into the compilation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1763571880