RFR: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing [v3]

[Theo Weidmann]

On Wed, 8 Jan 2025 08:09:10 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Theo Weidmann has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch '8345766-floating-mod-macro' of https://github.com/theoweidmannoracle/jdk into 8345766-floating-mod-macro
>>  - Use basic type instead
>
> src/hotspot/share/opto/divnode.cpp line 1409:
> 
>> 1407: }
>> 1408: 
>> 1409: Node* ModFNode::Ideal(PhaseGVN* phase, bool can_reshape) {
> 
> Can you quickly say why you congerted this from a `Value` to an `Ideal` method? I guess it is because before it used to be a simple `Node` with a single output, but now it is a `Call` with multiple outputs... Ok makes sense.

Yes, because it's a call now with multiple outputs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22786#discussion_r1908622479