RFR: 8350589: Investigate cleaner implementation of AArch64 ML-DSA intrinsic introduced in JDK-8348561 [v5]

[Andrew Dinn]

On Wed, 19 Mar 2025 00:41:55 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Andrew Dinn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - use references and const to avoid VSeq copying and fix int array arg issue
>>  - fix comment
>>  - fix invalid register argument
>>  - fix errors in comments
>>  - fix whitespace errors
>>  - Clearer implementation of AArch64 dilithium generator
>
> I'm not an expert, but this looks good overall, and I'm relying on Andrew's testing to verify the details.

@dean-long Thanks for the review!

@ferakocz

Do you have any comments to add regarding this restructuring? In particular, is the information in the comments clear and correct? I'd prefer confirmation from you that the patch is ok before committing this change.

I would also like to investigate whether your [ML_KEM PR](https://git.openjdk.org/jdk/pull/23663) might benefit from adopting a similar restructuring (i.e. using operations scheduled over vector sequences). It looks to me like that would be the case. Could you comment on that?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24026#issuecomment-2736189193