RFR: 8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself [v2]
Marc Chevalier
mchevalier at openjdk.org
Thu Mar 27 08:48:52 UTC 2025
On Thu, 27 Mar 2025 07:34:19 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix copyright and remove IgnoreUnrecognizedVMOptions and remove vm.debug
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/flag/TestCompileCommandFileWriter.java line 47:
>
>> 45: * @run driver jdk.test.lib.helpers.ClassFileInstaller jdk.test.whitebox.WhiteBox
>> 46: * @run junit/othervm -Xbootclasspath/a:. -DSkipWhiteBoxInstall=true -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
>> 47: * -XX:+WhiteBoxAPI compiler.lib.ir_framework.flag.TestCompileCommandFileWriter
>
> Do we really need the WhiteBoxAPI? `-XX:+IgnoreUnrecognizedVMOptions` can be removed as well. Please also update the copyright date.
We do need the WhiteBoxAPI. IgnoreUnrecognizedVMOptions removed, date updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24240#discussion_r2015967264
More information about the hotspot-compiler-dev
mailing list