RFR: 8357568: IGV: Show NULL and numbers up to 4 characters in "Condense graph" filter [v2]

[Christian Hagedorn]

On Fri, 23 May 2025 07:18:35 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> src/hotspot/share/opto/idealGraphPrinter.cpp line 676:
>> 
>>> 674:       } else if (t->base() == Type::AnyPtr) {
>>> 675:         if (t->is_ptr()->ptr() == TypePtr::Null) {
>>> 676:           print_prop(short_name, "NULL");
>> 
>> I'm surprised this doesn't trip over sources/TestNoNULL.java.
>
> Actually it does, see failures in github actions testing:
>> Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Test found 1 usages of 'NULL' in source files. See errors above.

Interesting! You're right. I haven't checked the testing results, yet. Should we just change to `Null` or make an exclusion in `TestNoNULL`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25393#discussion_r2104000789