RFR: 8364757: Missing Store nodes caused by bad wiring in PhaseIdealLoop::insert_post_loop [v5]

[Benoît Maillard]

On Tue, 16 Sep 2025 08:22:28 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - More minor refactoring and renaming
>>  - Minor refactor
>
> src/hotspot/share/opto/loopnode.hpp line 1384:
> 
>> 1382: 
>> 1383:   // Find the last memory node in the loop when following memory usages
>> 1384:   Node *find_mem_out_outer_strip_mined(Node* store, IdealLoopTree* outer_loop);
> 
> The name of the method is a bit confusing. And the comment seems to suggest something different than what the code says.

The name was really bad indeed, sorry for that. I have renamed it to `find_last_store_in_outer_loop`, and added a comment to explain why we have the guarantee of a linear graph here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27225#discussion_r2371664300