RFR (S): 8235403: Further cleanup to test serviceability/sa/ClhsdbCDSCore.java

[Igor Ignatyev]

the patch looks good to me.

I have a more generic question about this test though: I see we call cleanup() at almost all places which finish the test o way or another, I don't see why it's needed as jtreg is supposed to remove these files (unless -retain's value asks to preserve them), so if cleanup() isn't needed I'd like us to remove from one places but L#79 (where it serves as a defense from non empty work dir). if there are (good) reasons for cleanup to be called before exiting the test, shouldn't it also be called at L#115 and L#119?

Thanks,
-- Igor

> On Dec 5, 2019, at 8:21 AM, Ioi Lam <ioi.lam at oracle.com> wrote:
> 
> Looks good to me.
> 
> Thanks
> - Ioi
> 
> On 12/5/19 3:06 AM, Langer, Christoph wrote:
>> Hi,
>> 
>> please review this little test cleanup. When JDK-8234625: hs test serviceability/sa/ClhsdbCDSCore.java  fails on macOS 10.15 [0] was reviewed, there were further comments which didn't make it into the commit.
>> 
>> I think the check for MacOS version 10.15 should not be done, the writability check on /cores is enough. I also tried to improve some messages and added a try-with-resource around the usage of a Scanner instance.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8235403
>> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235403.0/
>> 
>> Thanks
>> Christoph
>> 
>> [0] https://bugs.openjdk.java.net/browse/JDK-8234625
>> 
>