RFR (S): 8235403: Further cleanup to test serviceability/sa/ClhsdbCDSCore.java

[Langer, Christoph]

Hi Igor,

> the patch looks good to me.

Thanks for reviewing

> I have a more generic question about this test though: I see we call cleanup()
> at almost all places which finish the test o way or another, I don't see why it's
> needed as jtreg is supposed to remove these files (unless -retain's value asks
> to preserve them), so if cleanup() isn't needed I'd like us to remove from one
> places but L#79 (where it serves as a defense from non empty work dir). if
> there are (good) reasons for cleanup to be called before exiting the test,
> shouldn't it also be called at L#115 and L#119?

Well, I think it's not too bad to actively call cleanup() , given that there might be a rather large core file lying around, occupying space. In line 115 and 119, no core file was probably created. However, I guess it would be still ok and defensive enough to call cleanup there as well - be it only to remove the shared archive file.

I'll add cleanup() calls at these locations and run it through the testing. If I don't find any problems, I'll push with them...

Cheers
Christoph