RFR: 8233328: fix minimal VM build on Linux s390x
Baesken, Matthias
matthias.baesken at sap.com
Tue Nov 5 08:54:27 UTC 2019
Hello, here is another webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8233328.2/
It adjusts the coding in macroAssembler_s390.cpp mentioned below .
Best regards, Matthias
From: Baesken, Matthias
Sent: Montag, 4. November 2019 12:27
To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
Subject: RFR: 8233328: fix minimal VM build on Linux s390x
Hello, please review the following change that fixes the "minimal VM" build on linuxs390x .
While looking into the issue I noticed that
MacroAssembler::generate_type_profiling
( in http://cr.openjdk.java.net/~mbaesken/webrevs/8233328.1/src/hotspot/cpu/s390/macroAssembler_s390.cpp.frames.html )
Is ununsed so I removed it (probably it is a left over from old jdk8 (?) times ) .
In
2929 void MacroAssembler::nmethod_UEP(Label& ic_miss) {
2930 #ifdef COMPILER2
2931 Register ic_reg = as_Register(Matcher::inline_cache_reg_encode());
2932 #else
2933 Register ic_reg = as_Register(0);
2934 #endif
We probably still need to replace as_Register(0); with something better , any suggestions ?
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8233328
http://cr.openjdk.java.net/~mbaesken/webrevs/8233328.1/
Thanks, Matthias
More information about the hotspot-dev
mailing list