RFR: 8257731: Remove excessive include of stubRoutines.hpp

David Holmes david.holmes at oracle.com
Sat Dec 5 05:41:02 UTC 2020


On 4/12/2020 7:46 pm, Aleksey Shipilev wrote:
> On Fri, 4 Dec 2020 00:48:16 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> 
>>>>> Make sure all builds are passed.
>>>>
>>>> @vnkozlov @coleenp I've tested tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5 on mach5, plus locally building arm, aarch64, s390, ppc64, and zero.
>>>
>>> Good. Please, list testing in your PR descriptions so that we know what you did.
>>
>>>>> Make sure all builds are passed.
>>>>
>>>>
>>>> @vnkozlov @coleenp I've tested tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5 on mach5, plus locally building arm, aarch64, s390, ppc64, and zero.
>>>
>>> Good. Please, list testing in your PR descriptions so that we know what you did.
>>
>> Done. I updated the PR descriptions.
> 
> I have a suggestion: let's wait until JDK 16 forks for stabilization before we do any `#include` reshuffling? There are build breakages from these changes, so it would be nice to have these breakages away from the stabilizing repository.

With sufficient pre-integration testing this should not be an issue. It 
seems for JDK-8257563 no GitHub actions were run and so numerous build 
variants were missed.

David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/1610
> 


More information about the hotspot-dev mailing list