RFR: 8257731: Remove excessive include of stubRoutines.hpp [v2]

Ioi Lam iklam at openjdk.java.net
Thu Dec 10 22:51:19 UTC 2020


> stubRoutines.hpp is unnecessarily included by thread.hpp and copy.hpp. This causes a large number of header files related to native code generation to be included by almost all HotSpot .o files.
> 
> - Before the fix, stubRoutines.hpp is included by 803 .o files.
> - After the fix, stubRoutines.hpp is included by 117 .o files.
> 
> The total number of included header files decreased from 252893 to 247631, or about 2%.
> 
> Note: the main change is the removal of stubRoutines.hpp in thread.hpp and copy.hpp. Unfortunately I have to fix quite a few missing dependencies in other source files that are revealed by the removal.
> 
> Testing: I've tested tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5 on mach5, plus locally building arm, aarch64, s390, ppc64, and zero.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into 8257731-reduce-include-of-stubRoutines-hpp
 - 8257731: Remove excessive include of stubRoutines.hpp

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1610/files
  - new: https://git.openjdk.java.net/jdk/pull/1610/files/9baf9a50..c4f2d8ea

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1610&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1610&range=00-01

  Stats: 32306 lines in 742 files changed: 24130 ins; 5389 del; 2787 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1610.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1610/head:pull/1610

PR: https://git.openjdk.java.net/jdk/pull/1610


More information about the hotspot-dev mailing list