RFR: 8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses [v2]

Harold Seigel hseigel at openjdk.java.net
Wed Dec 16 16:35:15 UTC 2020


On Tue, 15 Dec 2020 22:17:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8257700: Add logging for sealed classes in JVM_GetPermittedSubclasses
>
> src/hotspot/share/prims/jvm.cpp line 2129:
> 
>> 2127:   assert(c->is_instance_klass(), "must be");
>> 2128:   InstanceKlass* ik = InstanceKlass::cast(c);
>> 2129:   log_trace(class, sealed)("Calling GetPermittedSubclasses for %s type %s",
> 
> I don't know why this didn't complain about a missing ResourceMark, but can you add one just before line 2129 and it'll clean up any potential resource area uses for any external_name() calls.  They're not that expensive so one would do without conditionalization.

I added the ResourceMark in the latest commit. Thanks for pointing out that it was missing!
Harold

-------------

PR: https://git.openjdk.java.net/jdk/pull/1780


More information about the hotspot-dev mailing list