RFR: JDK-8256922: ppc, ppcle build broken after JDK-8254231 [v2]

Thomas Stuefe stuefe at openjdk.java.net
Tue Nov 24 08:31:00 UTC 2020


On Tue, 24 Nov 2020 07:42:06 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - include guard misnamed
>>  - Rename files
>
> src/hotspot/cpu/ppc/frame_ppc.hpp line 121:
> 
>> 119:   };
>> 120: 
>> 121:   #define _abi0(_component) \
> 
> When I was experimenting with this code, I thought to name it consistently with `_abi_reg_args_spill` definition a few lines below. That is, make it `_abi_reg_args`. Does that make more sense than `_abi0`?

Sure, but lets ask @RealLucy @TheRealMDoerr first to agree on a name.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1404


More information about the hotspot-dev mailing list