RFR: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest [v6]

[Mikhailo Seledtsov]

On Wed, 3 Mar 2021 05:13:22 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Using regular brackets in initializer list instead of curly brackets
>
> test/hotspot/gtest/concurrent_test_runner.inline.hpp line 27:
> 
>> 25: #define GTEST_CONCURRENT_TEST_RUNNER_INLINE_HPP
>> 26: 
>> 27: #include "threadHelper.inline.hpp"
> 
> Make sure you include all headers needed for this file. Includes should be self-contained, so pull everything they need (basically, you should be able to include it into an empty cpp file and it should build fine). You use Semaphore and some os::xxx functions, so you'd need at least os.hpp and wherever Semaphore lives.

Thank you for pointing this out. I will make the necessary updates.

> test/hotspot/gtest/concurrent_test_runner.inline.hpp line 69:
> 
>> 67:     testDurationMillis(testDurationMillisArg) {}
>> 68: 
>> 69:   virtual ~ConcurrentTestRunner() {}
> 
> Do we derive from this class? And delete via base pointers? If not, I'd remove this.

Not deriving from this class, I will remove the virtual destructor.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2436