RFR: 8290075: [JVMCI] only blessed methods can link against EventWriterFactory.getEventWriter [v3]

[Erik Gahlin]

On Mon, 22 Aug 2022 15:55:36 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Maybe I'm missing the point of these tests but I assume they are trying to exercise the blessed method checks in which case the IllegalAccessError message should be coming from here: https://github.com/openjdk/jdk/blob/master/src/hotspot/share/jfr/instrumentation/jfrResolution.cpp#L81
>> Instead, it is coming from the module access checks.
>> Please see more details at https://github.com/openjdk/jdk/pull/8383#discussion_r915755771
>
> Now I understand better what you are referring to, thanks for noticing this. I think your suggestion is good, it makes sense to make the tests better targeted. Please also add the --add-exports to the other tests as well. Thanks again for seeing this.

I think we want to test what is being shipped. From the beginning there was --add-exports, but then it was removed and we found issues (unexpected exception). Maybe we can have both, but I think it would be unfortunate to not test the "full scenario" (which might include registering an event).

-------------

PR: https://git.openjdk.org/jdk/pull/9449