RFR: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Wed Mar 2 02:10:01 UTC 2022
On Tue, 1 Mar 2022 23:34:38 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Thanks Coleen, seems the use of `set_mode_flags` is somewhat flawed as you can change any of the flags that it tries to force on/off simply by having them later on the command-line.
>>
>> You could do as @vnkozlov suggests and move this check into `compilerDefinitions.cpp` as `CompilerConfig::ergo_initialize()` is called just a few lines above this.
>
> Thanks Vladimir, that's a better place for it. There are other checks for inconsistent flags with -Xint in check_args_consistency(). One of the tests still fails with that change so I'll have to figure out why.
I moved the check but TieredStopAtLevel=0 still allocates code heaps for nmethods, so the check only checks for the -Xint in arguments. I don't know if this makes sense or not in the code heap allocation code, but the codecache/cli tests test for sizes of code heaps pass with this change.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7650
More information about the hotspot-dev
mailing list