RFR: 8302328: [s390x] Simplify asm_assert definition [v2]

Lutz Schmidt lucy at openjdk.org
Thu Apr 13 13:49:36 UTC 2023


On Thu, 13 Apr 2023 13:39:48 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> The request was to "move z_illtrap() after asm_assert()". For debug builds, you then get a descriptive assert message. For release builds, you at least have a security net.
>
> `z_bre` + `asm_assert(Assembler::bcondEqual, ...` still doesn't make sense to me.

z_bre is a "branch if equal". Everything is fine if both registers contain the same value. Otherwise, there is something wrong.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12822#discussion_r1165549006


More information about the hotspot-dev mailing list