RFR: 8319716: RISC-V: Add SHA-2 [v8]
Robbin Ehn
rehn at openjdk.org
Fri Dec 22 13:39:56 UTC 2023
On Fri, 22 Dec 2023 08:44:20 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 3935:
>>
>>> 3933: // x0 is not written, we known the number of vector elements.
>>> 3934:
>>> 3935: __ vsetivli(x0, 4, vset_sew, Assembler::m1, Assembler::ma, Assembler::ta);
>>
>> Currently, when MaxVectorSize < 16 UseRVV = false, so there are conditions when MaxVectorSize == 16 && UseRVV == true, in this case, `vsetivli` will not work as expected, and neither the following codes.
>>
>> And 128 bits is the common one?
>
> I see this is also pointed by @RealFYang
sha uses fixed width instructions, we don't no actually care about lmul in that sense.
We just need to set it correctly.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16562#discussion_r1435061598
More information about the hotspot-dev
mailing list