RFR: 8311946: add support for libgraal specific jtreg tests [v3]
Doug Simon
dnsimon at openjdk.org
Thu Jul 13 18:27:15 UTC 2023
On Thu, 13 Jul 2023 16:46:52 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Doug Simon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>>
>> - add support for vm.libgraal property and fix problems with vm.libgraal.enabled property
>> - Merge remote-tracking branch 'openjdk-jdk/master' into JDK-8311946
>> - fix wrong flag name
>> - add support for vm.libgraal.enabled property
>
> test/jtreg-ext/requires/VMProps.java line 127:
>
>> 125: map.put("vm.graal.enabled", this::isGraalEnabled);
>> 126: // vm.libgraal is true if the libgraal shared library file is present
>> 127: map.put("vm.libgraal", this::hasLibraal);
>
> May be the property also should be named "vm.hasLibgraal" to be clear what it means.
I'm not so sure. The current naming seems consistent with other existing properties:
map.put("vm.jvmti", this::vmHasJVMTI);
map.put("vm.jvmci", this::vmJvmci);
However, I can change it if you insist.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14851#discussion_r1262919222
More information about the hotspot-dev
mailing list