RFR: 8301996: Move field resolution information out of the cpCache [v10]

Martin Doerr mdoerr at openjdk.org
Sat Jul 22 13:19:46 UTC 2023


On Fri, 21 Jul 2023 21:14:17 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> 8301996: Move field resolution information out of the cpCache
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Missing semicolon

src/hotspot/share/oops/resolvedFieldEntry.hpp line 53:

> 51:   u2 _field_index;              // Index into field information in holder InstanceKlass
> 52:   u2 _cpool_index;              // Constant pool index
> 53:   u1 _tos;                      // TOS state

`_tos_state` would avoid confusion.

src/hotspot/share/oops/resolvedFieldEntry.hpp line 125:

> 123:     _tos = tos;
> 124: 
> 125:     // This has to be done last

Maybe better use `OrderAccess::release()` here instead of 2x `Atomic::release_store` above? That would fit to the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1271295154
PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1271294973


More information about the hotspot-dev mailing list