RFR: 8307190: Refactor ref_at methods in Constant Pool [v2]

[Matias Saavedra Silva]

On Thu, 11 May 2023 21:52:20 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotConstantPool.java line 438:
>> 
>>> 436:      *
>>> 437:      * @param which constant pool index or constant pool cache index
>>> 438:      * @param opcode bytecode
>> 
>> Is this a param?  You should remove the jvmci changes because they're not needed for this change.
>
> Or should the comment say that 'which' is the constant pool index only in this case?

The JVMCI should still be updated to match the internal functionality.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13872#discussion_r1196854307