RFR: 8334999: RISC-V: implement AES single block encryption/decryption intrinsics [v2]

ArsenyBochkarev duke at openjdk.org
Sun Jul 14 13:17:20 UTC 2024


On Tue, 9 Jul 2024 08:36:16 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 2282:
>> 
>>> 2280:     __ vrev8_v(vtmp1, vtmp1);
>>> 2281:     __ vrev8_v(vtmp2, vtmp2);
>>> 2282:   }
>> 
>> Please leave a new line after each of these newly-added functions.
>
> BTW: Did you compare this with the openssl version which also makes use of `vaesz_vs` instruction from `Zvkned`  [1]? 
> 
> [1] https://github.com/openssl/openssl/blob/master/crypto/aes/asm/aes-riscv64-zvkb-zvkned.pl

Done!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19960#discussion_r1677133443


More information about the hotspot-dev mailing list