RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v2]

[Chen Liang]

On Thu, 21 Nov 2024 06:10:29 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updated testcase
>
> test/hotspot/jtreg/runtime/cds/appcds/jvmti/CFLH/MultiReleaseJars.java line 48:
> 
>> 46:     static final String MAJOR_VERSION_STRING = String.valueOf(MAJOR_VERSION);
>> 47: 
>> 48:     static String[] getMain() {
> 
> Can't you just define these as source files in the test directory rather than creating them dynamically?

I think the concern may be that we want to avoid license headers.

However, we should still use text blocks instead of these string arrays for such inlined source files.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22262#discussion_r1852528008