RFR: 8365147: AArch64: Replace DMB + LD + DMB with LDAR for C1 volatile field loads
Samuel Chee
duke at openjdk.org
Tue Aug 12 15:11:13 UTC 2025
On Tue, 12 Aug 2025 14:59:40 GMT, Samuel Chee <duke at openjdk.org> wrote:
> Replaces the DMB ISH + LD + DMB ISHLD sequence with LDAR for volatile field loads - for example, AtomicLong::get.
>
> This is valid, as originally the DMBs were necessary due to the case described here - https://bugs.openjdk.org/browse/JDK-8179954. As in the rare case where the LD can be reordered with an LDAR or STLR from the C2 implementation for stores and loads, these DMBs are required.
> However, acquire/release operations use a sequentially consistent model which does not allow reordering between them. Hence, the LD can be replaced with an LDAR to disallow reordering with a STLR/LDAR and the first DMB can be removed.
>
> The LDAR has acquire semantics, so it's impossible for memory accesses after to be reordered before; the DMB ISHLD is not required. Therefore, a singular LDAR is sufficient.
>
> This excludes floats and doubles, as they do not have equivalent load-acquire instructions.
Passes entire jcstress test-suite.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26748#issuecomment-3179761865
More information about the hotspot-dev
mailing list