RFR (S): 8026047: add regression test for DisableExplicitGC flag

Tao Mao tao.mao at oracle.com
Tue Oct 8 16:23:58 UTC 2013


Hi Filipp,

Thank you for putting this up.

Here is the review:

1. Please consider a cleaner way to parse vm options and maybe take this 
for reference.

/test/gc/init/TestHandleExceedingProcessSizeLimitIn32BitBuilds.java

2. It's better to make variables explicit: I mean,

disableGC -> disableExplicitGC

Thanks.
Tao

On 10/8/13 8:30 AM, Filipp Zhinkin wrote:
> Hi,
>
> I would like to get couple reviews on regression test for 
> DisableExplicitGC flag.
>
> It verifies that System.gc() calls did not trigger garbage collection 
> if DisableExplicitGC is turned on and vice versa.
>
> Bug ID:  https://bugs.openjdk.java.net/browse/JDK-8026047
> Webrev:  http://cr.openjdk.java.net/~kshefov/8026047/webrev.00/
> Testing: manual on local host, automated on various platforms.
>
> Thanks,
> Filipp.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20131008/3b61d1fb/attachment.htm>


More information about the hotspot-gc-dev mailing list