RFR (S): 8026047: add regression test for DisableExplicitGC flag

[Filipp Zhinkin]

Hi Tao,

thank you for looking at it.

On 10/08/2013 08:23 PM, Tao Mao wrote:
> Hi Filipp,
>
> Thank you for putting this up.
>
> Here is the review:
>
> 1. Please consider a cleaner way to parse vm options and maybe take 
> this for reference.
>
> /test/gc/init/TestHandleExceedingProcessSizeLimitIn32BitBuilds.java
I decided to use such complicated way to parse options, because java 
process started
by ProcessBuilder will fail if there are more than one space between 
options in test.java.opts.
But I've checked it, and looks like jtreg removes all extra spaces by 
itself, so I was doing a redundant work. :)

And yes, I agree, putting all extra options in array's static 
initializer look much cleaner.
>
> 2. It's better to make variables explicit: I mean,
>
> disableGC -> disableExplicitGC
Thank you for pointing on it, I'll fix that.

Filipp.
>
> Thanks.
> Tao
>
> On 10/8/13 8:30 AM, Filipp Zhinkin wrote:
>> Hi,
>>
>> I would like to get couple reviews on regression test for 
>> DisableExplicitGC flag.
>>
>> It verifies that System.gc() calls did not trigger garbage collection 
>> if DisableExplicitGC is turned on and vice versa.
>>
>> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8026047
>> Webrev: http://cr.openjdk.java.net/~kshefov/8026047/webrev.00/
>> Testing: manual on local host, automated on various platforms.
>>
>> Thanks,
>> Filipp.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20131009/4fc64d14/attachment.htm>