RFR (XXS): 8038829: G1: More useful information in a few assert messages

Bengt Rutisson bengt.rutisson at oracle.com
Tue Apr 1 06:03:33 UTC 2014


Thanks for the reviews Stefan and Jon!

Bengt

On 4/1/14 12:41 AM, Jon Masamitsu wrote:
> Looks good.
>
> Reviewed.
>
> Jon
>
> On 3/31/14 8:14 AM, Bengt Rutisson wrote:
>>
>> Hi everyone,
>>
>> Could I have a couple of reviews of this very small fix to some 
>> assert messages:
>>
>> http://cr.openjdk.java.net/~brutisso/8038829/webrev.00/
>>
>> https://bugs.openjdk.java.net/browse/JDK-8038829
>>
>> In VerifyRegionListsClosure::doHeapRegion() the assert messages print 
>> the region_num() value of the heap region. This value is the the 
>> number of regions that a humongous object covers. It is only relevant 
>> for starts humongous regions. For all other regions this value is 1.
>>
>> Most likely the intended value was hrs_index(), which is a sequential 
>> number enumerating all heap regions.
>>
>> Thanks,
>> Bengt
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20140401/d8d7a810/attachment.htm>


More information about the hotspot-gc-dev mailing list