RFR(M): 8038498: Fix includes and C inlining after 8035330

[Lindenmaier, Goetz]

Hi Thomas, 

no, no problem with this!  But correct attribution is a nice-to-have ;)

Best regards,
  Goetz.

-----Original Message-----
From: Thomas Schatzl [mailto:thomas.schatzl at oracle.com] 
Sent: Mittwoch, 16. April 2014 21:04
To: Volker Simonis
Cc: Lindenmaier, Goetz; hotspot-gc-dev at openjdk.java.net
Subject: Re: RFR(M): 8038498: Fix includes and C inlining after 8035330

Hi,

On Wed, 2014-04-16 at 18:38 +0200, Volker Simonis wrote:
> Hi Thomas,
>
> thanks for sponsoring this change.
>
> I just wonder why the downported change in jdk8u
> (http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/bfdf528be8e8) is
> attributed to you and not to Goetz? 
> In the jdk9 repositories
> (http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/rev/4c16a27793eb) Goetz
> is correctly mentioned as the author.

  that's my fault. When committing the backport a few days later, I
forgot to make Goetz the author (i.e. did not use "hg commit -u goetz",
or did not do a straight import of that patch - I do not remember). I
never intended to claim authorship for the change/commit.

There were no changes in the backport, just a straight re-commit. So
there was no review necessary. From the bugtracker (and this mail
thread) it should be clear (at least now) that this is "only" a
backport, and the reason for this difference human error.

Unfortunately the commit message cannot be changed any more.

Interestingly the push hook did not complain that the author is also
mentioned as reviewer :) (Then again, Stefan K is sufficient to pass).

I will try to be more wary of this next time. I hope this poses no
problem.

Sorry,
  Thomas