Request for review (s) : 8017462: G1: guarantee fails with UseDynamicNumberOfGCThreads

Jon Masamitsu jon.masamitsu at oracle.com
Mon Mar 30 22:40:33 UTC 2015


I'm moving  Bengt's question about using @requires into
its own thread because it deserves it.

On 03/30/2015 04:03 AM, Bengt Rutisson wrote:
>
>
>
>>
>>>
>>> I guess this is a more general question. Should we use @requires to 
>>> avoid running the same test many times or should we only use it when 
>>> the test actually requires a specific GC configuration?
>>
>> I'll happily take guidance on this point.   Only using it when tests 
>> actually requires a specific
>> GC sounds OK.
>
> I'm also not sure, so my question was really a question. Is this how 
> we want to make sure that a generic test is only run once? There are 
> other ways...test groups, nightly batch configuration etc...

I like that @requires is local to the test so easy to change.   Also that it
works for JPRT when JPRT runs the jtreg tests.

Jon




More information about the hotspot-gc-dev mailing list