RFR: 8328792: Parallel: Refactor PSParallelCompact::summary_phase [v9]

[Ivan Walulya]

On Wed, 10 Apr 2024 14:27:04 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> src/hotspot/share/gc/parallel/psParallelCompact.cpp line 1143:
>> 
>>> 1141: 
>>> 1142:   if (maximum_compaction || is_old_gen_overflowing || is_interval_ended || is_region_full) {
>>> 1143:     _maximum_compaction_gc_num = total_invocations;
>> 
>> Based on the function name, we don't expect it to do more than `reassess_maximum_compaction`, additionally this modification also requires that we call `reassess_maximum_compaction` even when `maximum_compaction` is already true. Is is possible to decouple these two: `reassess_maximum_compaction` and `_maximum_compaction_gc_num = total_invocations`?
>
> `_maximum_compaction_gc_num` is on the same abstraction level as the checking denoted as "JVM flags". Separating them will probably make code harder to follow.

Not sure I agree, but it is a minor issue, not a blocker.

LGTM!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18451#discussion_r1560723714