RFR(XS): JDK-8068655 frame::safe_for_sender() computes incorrect sender_sp value for interpreted frames

Coleen Phillimore coleen.phillimore at oracle.com
Mon Jan 26 18:58:37 UTC 2015


Yes, I agree this looks good.  Thanks for the comment about 
sender_sp_offset only being valid for compiled frames.

Coleen

On 1/26/15, 1:24 PM, Daniel D. Daugherty wrote:
> On 1/26/15 7:40 AM, Frederic Parain wrote:
>> Greetings,
>>
>> Please review this small fix in the frame verification code.
>> The bug report includes a detailed description of the issue.
>>
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8068655
>>
>> Webrev:
>> http://cr.openjdk.java.net/~fparain/8068655/webrev.00/
>
> src/cpu/x86/vm/frame_x86.cpp
>     I like that sender_sp, sender_pc, and saved_fp are now declared
>     together and set together. Much more clean.
>
> Thumbs up.
>
> Dan
>
> P.S.
> It does seem a little strange that the 'link_offset' enum is
> defined in a section of src/cpu/x86/vm/frame_x86.hpp that is
> commented as "C++ interpreter".
>
>
>>
>> Thanks,
>>
>> Fred
>>
>



More information about the hotspot-runtime-dev mailing list